add phan

src/Demo/Parser.php

@@ -35,11 +35,11 @@ class Parser {
 
     public function analyse(string $path): ParsedDemo {
         $data = $this->rawParser->parse($path);
-        if (!is_array($data)) {
+        if (is_array($data)) {
+            return $this->handleData($data);
+        } else {
             throw new \InvalidArgumentException('Error parsing demo');
         }
-
-        return $this->handleData($data);
     }
 
     private function handleData(array $data): ParsedDemo {
@@ -60,7 +60,8 @@ class Parser {
 
         foreach ($data['chat'] as $message) {
             if (isset($message['from'])) {
-                $chat[] = new ChatMessage($message['from'], (int) floor(($message['tick'] - $data['startTick']) * $intervalPerTick), $message['text']);
+                $chat[] = new ChatMessage($message['from'],
+                    (int)floor(($message['tick'] - $data['startTick']) * $intervalPerTick), $message['text']);
             }
         }
 
@@ -79,13 +80,14 @@ class Parser {
                     $player['userId'],
                     $this->convertSteamIdToCommunityId($player['steamId']),
                     $player['team'],
-                    $this->getClassName((int) $class)
+                    $this->getClassName((int)$class)
                 );
             }
         }
 
         $kills = array_map(function (array $death) {
-            return new ParsedKill($death['killer'] ?? 0, $death['assister'] ?? 0, $death['victim'] ?? 0, $death['weapon']);
+            return new ParsedKill($death['killer'] ?? 0, $death['assister'] ?? 0, $death['victim'] ?? 0,
+                $death['weapon']);
         }, $data['deaths']);
 
         return new ParsedDemo(

src/Demo/RawParser.php

@@ -5,7 +5,7 @@ declare(strict_types=1);
 namespace Demostf\API\Demo;
 
 use GuzzleHttp\Client;
-use GuzzleHttp\Exception\GuzzleException;
+use GuzzleHttp\Exception\RequestException;
 
 /**
  * Wrapper around demo.js parser.
@@ -32,7 +32,7 @@ class RawParser {
             } else {
                 return $result;
             }
-        } catch (GuzzleException $e) {
+        } catch (RequestException $e) {
             if (strpos($e->getMessage(), 'cURL error 52') !== false) {
                 throw new \Exception('Failed to parse demo, can\'t reach demo parser');
             }

src/Providers/BaseProvider.php

@@ -21,6 +21,15 @@ class BaseProvider {
      */
     protected $db;
 
+    /**
+     * BaseProvider constructor.
+     * @param Connection $connection
+     *
+     * The DBAL connection used will always be a PDO
+     * but phan isn't aware of this.
+     *
+     * @suppress PhanTypeMismatchArgument
+     */
     public function __construct(Connection $connection) {
         $this->connection = $connection;
         $this->db = new Database($connection->getWrappedConnection());