safe

.travis.yml

@@ -8,5 +8,4 @@ matrix:
     - rust: nightly
   fast_finish: true
 script:
-  - cargo test --all
+  - cargo test --all
-  - cargo test --all --all-features

Cargo.toml

@@ -20,6 +20,3 @@ memchr = "2.2"
 maplit = "1.0.1"
 
 [workspace]
-
-[features]
-unsafe = []

src/buffer.rs

@@ -86,27 +86,15 @@ where
     }
 
     fn read_usize_bytes(&self, byte_index: usize) -> [u8; USIZE_SIZE] {
-        if cfg!(feature = "unsafe") {
+        if byte_index + USIZE_SIZE <= self.bytes.len() {
-            use std::mem::transmute;
+            self.bytes[byte_index..byte_index + USIZE_SIZE]
-            // panic instead of accessing out of bounds data when the caller didn't do it's job bounds checking
+                .try_into()
-            // due to the magic of branch prediction and this check "always" passing, the cost for this
+                .unwrap()
-            // is below the point of being measurable by `cargo bench`
-            unsafe {
-                let ptr = self.bytes.as_ptr().add(byte_index);
-                *transmute::<_, &[u8; USIZE_SIZE]>(ptr)
-            }
         } else {
-            if byte_index + USIZE_SIZE <= self.bytes.len() {
+            let mut bytes = [0; USIZE_SIZE];
-                self.bytes[byte_index..byte_index + USIZE_SIZE]
+            let copy_bytes = self.bytes.len() - byte_index;
-                    .try_into()
+            bytes[0..copy_bytes].copy_from_slice(&self.bytes[byte_index..byte_index + copy_bytes]);
-                    .unwrap()
+            bytes
-            } else {
-                let mut bytes = [0; USIZE_SIZE];
-                let copy_bytes = self.bytes.len() - byte_index;
-                bytes[0..copy_bytes]
-                    .copy_from_slice(&self.bytes[byte_index..byte_index + copy_bytes]);
-                bytes
-            }
         }
     }