From b1b4ac3ce9f4e425e1ae5b3fb70c000214e949e4 Mon Sep 17 00:00:00 2001
From: Robin Appelman <robin@icewind.nl>
Date: Mon, 17 Aug 2026 19:04:46 +0200
Subject: [PATCH] clippy fixes

---
 src/cloud.rs   | 10 ++++------
 src/main.rs    |  4 +---
 src/network.rs |  8 +++-----
 src/php.rs     |  5 ++---
 src/proxy.rs   |  5 ++---
 src/script.rs  |  6 +++---
 6 files changed, 15 insertions(+), 23 deletions(-)

diff --git a/src/cloud.rs b/src/cloud.rs
index 7783d99..d87cf4f 100644
--- a/src/cloud.rs
+++ b/src/cloud.rs
@@ -711,15 +711,14 @@ impl Cloud {
             .await
             .into_diagnostic()
             .wrap_err("Failed to remove network")?;
-        if self.workdir.exists() {
-            if let Err(e) = remove_dir_all(self.workdir)
+        if self.workdir.exists()
+            && let Err(e) = remove_dir_all(self.workdir)
                 .await
                 .into_diagnostic()
                 .wrap_err("Failed to remove work directory")
             {
                 eprintln!("{}", e);
             }
-        }
 
         remove_worktrees_for_instance(config, &self.id).await?;
 
@@ -804,8 +803,8 @@ impl Cloud {
         let mut containers_by_id: HashMap<String, (Option<_>, Vec<_>)> = HashMap::new();
         for container in containers {
             let labels = container.labels.clone().unwrap_or_default();
-            if let Some(cloud_id) = labels.get("haze-cloud-id") {
-                if match filter.as_ref() {
+            if let Some(cloud_id) = labels.get("haze-cloud-id")
+                && match filter.as_ref() {
                     Some(filter) => cloud_id.contains(filter),
                     None => true,
                 } {
@@ -816,7 +815,6 @@ impl Cloud {
                         entry.1.push(container)
                     }
                 }
-            }
         }
 
         let mut sortable_containers: Vec<_> = containers_by_id
diff --git a/src/main.rs b/src/main.rs
index db2febc..ffda7ec 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -92,8 +92,7 @@ async fn main() -> Result<ExitCode> {
                 let cache_dir = cache_dir.into_diagnostic()?;
                 if let Some(id) = cache_dir.file_name().to_str()
                     && id.starts_with("haze-")
-                {
-                    if !retain.iter().any(|cloud| cloud.id == id) {
+                    && !retain.iter().any(|cloud| cloud.id == id) {
                         let path = cache_dir.path();
                         // By default, the worktrees live within the work dir, we do not want to delete it here.
                         if path == config.worktree_dir {
@@ -110,7 +109,6 @@ async fn main() -> Result<ExitCode> {
                             })?;
                         }
                     }
-                }
             }
 
             prune_worktrees(&config)?;
diff --git a/src/network.rs b/src/network.rs
index 0b25f2c..386e13c 100644
--- a/src/network.rs
+++ b/src/network.rs
@@ -10,13 +10,11 @@ pub async fn clear_networks(docker: &Docker, instances: &[Cloud]) -> Result<()>
         .into_diagnostic()
         .wrap_err("Failed to list docker networks")?;
     for network in networks {
-        if let Some(name) = network.name.as_deref() {
-            if let Some(id) = name.strip_prefix("haze-") {
-                if !instances.iter().any(|cloud| cloud.id == id) {
+        if let Some(name) = network.name.as_deref()
+            && let Some(id) = name.strip_prefix("haze-")
+                && !instances.iter().any(|cloud| cloud.id == id) {
                     docker.remove_network(name).await.ok();
                 }
-            }
-        }
     }
     Ok(())
 }
diff --git a/src/php.rs b/src/php.rs
index 82f5db7..bb4764c 100644
--- a/src/php.rs
+++ b/src/php.rs
@@ -126,8 +126,8 @@ impl PhpVersion {
 
         let image_version = image_version(docker, self.image()).await;
         let haze_version = ImageVersion::from_str(env!("CARGO_PKG_VERSION"));
-        if let (Some(image_version), Ok(haze_version)) = (image_version, haze_version) {
-            if image_version < haze_version {
+        if let (Some(image_version), Ok(haze_version)) = (image_version, haze_version)
+            && image_version < haze_version {
                 eprintln!(
                     "{}: image version is out of date, run {} to update.",
                     "Warning".red(),
@@ -136,7 +136,6 @@ impl PhpVersion {
                 eprintln!("         Haze  version: {}", haze_version.bright_yellow());
                 eprintln!("         Image version: {}", image_version.bright_yellow());
             }
-        }
 
         let options = Some(CreateContainerOptions {
             name: Some(id.to_string()),
diff --git a/src/proxy.rs b/src/proxy.rs
index 1f270fa..ffc6e4c 100644
--- a/src/proxy.rs
+++ b/src/proxy.rs
@@ -201,12 +201,11 @@ async fn serve(instances: ActiveInstances, listen: String, base_address: String)
         }
     } else {
         let listen: PathBuf = listen.into();
-        if let Some(parent) = listen.parent() {
-            if !parent.exists() {
+        if let Some(parent) = listen.parent()
+            && !parent.exists() {
                 create_dir_all(parent).into_diagnostic()?;
                 set_permissions(parent, PermissionsExt::from_mode(0o755)).into_diagnostic()?;
             }
-        }
         let _ = tokio::fs::remove_file(&listen).await;
 
         let listener = UnixListener::bind(&listen).unwrap();
diff --git a/src/script.rs b/src/script.rs
index a20951a..fe4d026 100644
--- a/src/script.rs
+++ b/src/script.rs
@@ -57,10 +57,10 @@ pub async fn run_script(
         .dont_create(),
     );
 
-    let cloud = setup(docker, options, &config).await?;
+    let cloud = setup(docker, options, config).await?;
     cloud
         .exec(
-            &docker,
+            docker,
             vec![shell.to_string(), target_path.into_string()],
             true,
             get_forward_env(),
@@ -68,7 +68,7 @@ pub async fn run_script(
         .await?;
 
     if mode == ScriptMode::Shell {
-        cloud.destroy(&docker, &config).await?;
+        cloud.destroy(docker, config).await?;
     }
 
     Ok(())