use a string based buffer for Read/Write streams

This commit is contained in:
Robin Appelman 2021-03-05 15:35:10 +01:00
commit 0d9341c527
6 changed files with 184 additions and 38 deletions

View file

@ -83,7 +83,8 @@ abstract class AbstractShareTest extends TestCase {
public function fileDataProvider() {
return [
['Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua'],
['Mixed language, 日本語 が わからか and Various _/* characters \\|” €']
['Mixed language, 日本語 が わからか and Various _/* characters \\|” €'],
[str_repeat('Long text with lots of characters so we get a resulting string that tests the chunked writing and reading properly', 100)]
];
}
@ -418,6 +419,23 @@ abstract class AbstractShareTest extends TestCase {
$this->assertEquals(file_get_contents($sourceFile), $content);
}
/**
* @dataProvider nameAndDataProvider
*/
public function testReadStreamChunked($name, $text) {
$sourceFile = $this->getTextFile($text);
$this->share->put($sourceFile, $this->root . '/' . $name);
$fh = $this->share->read($this->root . '/' . $name);
$content = "";
while (!feof($fh)) {
$content .= fread($fh, 8192);
}
fclose($fh);
$this->share->del($this->root . '/' . $name);
$this->assertEquals(file_get_contents($sourceFile), $content);
}
/**
* @dataProvider invalidPathProvider
*/
@ -441,6 +459,24 @@ abstract class AbstractShareTest extends TestCase {
unlink($tmpFile1);
}
/**
* @dataProvider nameAndDataProvider
*/
public function testWriteStreamChunked($name, $text) {
$fh = $this->share->write($this->root . '/' . $name);
foreach (str_split($text, 8192) as $chunk) {
fwrite($fh, $chunk);
}
fclose($fh);
$tmpFile1 = tempnam('/tmp', 'smb_test_');
$this->share->get($this->root . '/' . $name, $tmpFile1);
$this->assertEquals($text, file_get_contents($tmpFile1));
$this->share->del($this->root . '/' . $name);
unlink($tmpFile1);
}
public function testAppendStream() {
$name = 'foo.txt';
$fh = $this->share->append($this->root . '/' . $name);