robin/smb
1
0
Fork 0
mirror of https://codeberg.org/icewind/SMB.git synced 2026-06-03 17:24:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

filter extra modify changes in tests

Browse source
This commit is contained in:
Robin Appelman 2016-12-08 16:22:38 +01:00
commit 239a6ea3c8
1 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

23
tests/NotifyHandlerTest.php
View file

@ -26,10 +26,26 @@ class NotifyHandlerTest extends TestCase {
$this->server = new \Icewind\SMB\Server($this->config->host, $this->config->user, $this->config->password); $this->server = new \Icewind\SMB\Server($this->config->host, $this->config->user, $this->config->password);
} }
/**
* sometimes smb adds modified changes in the mix for shits and giggles
*
* filter them out so we can compare changes properly
*
* @param array $changes
* @return array
*/
private function filterModifiedChanges(array $changes) {
return array_values(array_filter($changes, function (Change $change) {
return $change->getCode() !== INotifyHandler::NOTIFY_MODIFIED;
}));
}
public function testGetChanges() { public function testGetChanges() {
$share = $this->server->getShare($this->config->share); $share = $this->server->getShare($this->config->share);
$process = $share->notify(''); $process = $share->notify('');
usleep(1000 * 100);// give it some time to start listening
$share->put(__FILE__, 'source.txt'); $share->put(__FILE__, 'source.txt');
$share->rename('source.txt', 'target.txt'); $share->rename('source.txt', 'target.txt');
$share->del('target.txt'); $share->del('target.txt');
@ -41,11 +57,10 @@ class NotifyHandlerTest extends TestCase {
new Change(INotifyHandler::NOTIFY_ADDED, 'source.txt'), new Change(INotifyHandler::NOTIFY_ADDED, 'source.txt'),
new Change(INotifyHandler::NOTIFY_RENAMED_OLD, 'source.txt'), new Change(INotifyHandler::NOTIFY_RENAMED_OLD, 'source.txt'),
new Change(INotifyHandler::NOTIFY_RENAMED_NEW, 'target.txt'), new Change(INotifyHandler::NOTIFY_RENAMED_NEW, 'target.txt'),
new Change(INotifyHandler::NOTIFY_MODIFIED, 'target.txt'),
new Change(INotifyHandler::NOTIFY_REMOVED, 'target.txt'), new Change(INotifyHandler::NOTIFY_REMOVED, 'target.txt'),
]; ];
$this->assertEquals($expected, $changes); $this->assertEquals($expected, $this->filterModifiedChanges($changes));
} }
public function testChangesSubdir() { public function testChangesSubdir() {
@ -53,7 +68,7 @@ class NotifyHandlerTest extends TestCase {
try { try {
$share->mkdir('sub'); $share->mkdir('sub');
} catch (AlreadyExistsException $e){ } catch (AlreadyExistsException $e) {
} }
$process = $share->notify('sub'); $process = $share->notify('sub');
@ -71,7 +86,7 @@ class NotifyHandlerTest extends TestCase {
]; ];
$share->rmdir('sub'); $share->rmdir('sub');
$this->assertEquals($expected, $changes); $this->assertEquals($expected, $this->filterModifiedChanges($changes));
} }
public function testListen() { public function testListen() {