reduce code complexity a bit

src/Parser.php

@@ -20,6 +20,8 @@ use Icewind\SMB\Exception\NotEmptyException;
 use Icewind\SMB\Exception\NotFoundException;
 
 class Parser {
+	const MSG_NOT_FOUND = 'Error opening local file ';
+
 	/**
 	 * @var \Icewind\SMB\TimeZoneProvider
 	 */
@@ -32,46 +34,45 @@ class Parser {
 		$this->timeZoneProvider = $timeZoneProvider;
 	}
 
+	private function getErrorCode($line) {
+		$parts = explode(' ', $line);
+		foreach ($parts as $part) {
+			if (substr($part, 0, 9) === 'NT_STATUS') {
+				return $part;
+			}
+		}
+		return false;
+	}
+
 	public function checkForError($output, $path) {
-		if (count($output) === 0) {
+		if (strpos($output[0], 'does not exist')) {
-			return true;
+			throw new NotFoundException($path);
-		} else {
+		}
-			if (strpos($output[0], 'does not exist')) {
+		$error = $this->getErrorCode($output[0]);
+
+		if (substr($output[0], 0, strlen(self::MSG_NOT_FOUND)) === self::MSG_NOT_FOUND) {
+			$localPath = substr($output[0], strlen(self::MSG_NOT_FOUND));
+			throw new InvalidResourceException('Failed opening local file "' . $localPath . '" for writing');
+		}
+
+		switch ($error) {
+			case ErrorCodes::PathNotFound:
+			case ErrorCodes::ObjectNotFound:
+			case ErrorCodes::NoSuchFile:
 				throw new NotFoundException($path);
-			}
+			case ErrorCodes::NameCollision:
-			$parts = explode(' ', $output[0]);
+				throw new AlreadyExistsException($path);
-			$error = false;
+			case ErrorCodes::AccessDenied:
-			foreach ($parts as $part) {
+				throw new AccessDeniedException($path);
-				if (substr($part, 0, 9) === 'NT_STATUS') {
+			case ErrorCodes::DirectoryNotEmpty:
-					$error = $part;
+				throw new NotEmptyException($path);
-				}
+			case ErrorCodes::FileIsADirectory:
-			}
+			case ErrorCodes::NotADirectory:
-
+				throw new InvalidTypeException($path);
-			$notFoundMsg = 'Error opening local file ';
+			case ErrorCodes::SharingViolation:
-			if (substr($output[0], 0, strlen($notFoundMsg)) === $notFoundMsg) {
+				throw new FileInUseException($path);
-				$localPath = substr($output[0], strlen($notFoundMsg));
+			default:
-				throw new InvalidResourceException('Failed opening local file "' . $localPath . '" for writing');
+				throw Exception::unknown($path, $error);
-			}
-
-			switch ($error) {
-				case ErrorCodes::PathNotFound:
-				case ErrorCodes::ObjectNotFound:
-				case ErrorCodes::NoSuchFile:
-					throw new NotFoundException($path);
-				case ErrorCodes::NameCollision:
-					throw new AlreadyExistsException($path);
-				case ErrorCodes::AccessDenied:
-					throw new AccessDeniedException($path);
-				case ErrorCodes::DirectoryNotEmpty:
-					throw new NotEmptyException($path);
-				case ErrorCodes::FileIsADirectory:
-				case ErrorCodes::NotADirectory:
-					throw new InvalidTypeException($path);
-				case ErrorCodes::SharingViolation:
-					throw new FileInUseException($path);
-				default:
-					throw Exception::unknown($path, $error);
-			}
 		}
 	}
 

src/Share.php

@@ -401,7 +401,11 @@ class Share extends AbstractShare {
 	 * @return bool
 	 */
 	protected function parseOutput($lines, $path = '') {
-		return $this->parser->checkForError($lines, $path);
+		if (count($lines) === 0) {
+			return true;
+		} else {
+			return $this->parser->checkForError($lines, $path);
+		}
 	}
 
 	/**