dont attempt to deserialize bracketed strings as arrays if they contain more brackets

README.md

@@ -16,7 +16,7 @@ well only the serde data model not every type might deserialize properly.
 
 - Because the boolean values `0` and `1` can't be distinguished from numbers, it
   is not possible to use booleans in untagged enums.
-- When deserializing arrays by settings the same key multiple times, the keys
+- When deserializing arrays by setting the same key multiple times, the keys
   have to be consecutive.
 
   ```vdf

src/entry/mod.rs

@@ -842,6 +842,18 @@ fn test_parse_entry() {
 }
 
 pub(crate) fn string_is_array(string: &str) -> bool {
-    (string.starts_with('[') && string.ends_with(']'))
-        || (string.starts_with('{') && string.ends_with('}'))
+    if !((string.starts_with('[') && string.ends_with(']'))
+        || (string.starts_with('{') && string.ends_with('}')))
+    {
+        return false;
+    }
+
+    let contents = &string[1..string.len() - 1];
+
+    // no nested arrays
+    if contents.contains(['{', '[']) {
+        return false;
+    }
+
+    true
 }

tests/data/messy.vdf

@@ -7,6 +7,8 @@
     array 2
     array "3"
     windows_path "C:\test\no newline"
+    bracket_string "[{]"
+    ignored_bracket_string "[{]"
 
     \\"$translucent" 1 // this is real vdf written by real valve developers
     "$envmaptint" .5 .5 .5

tests/serde.rs

@@ -43,6 +43,7 @@ enum Expected {
         empty: (),
         array: Vec<u32>,
         windows_path: String,
+        bracket_string: String,
         #[serde(rename = r#"\\"$translucent""#)]
         translucent: bool,
         #[serde(rename = "$envmaptint")]
@@ -255,7 +256,6 @@ fn test_serde_table(path: &str) {
 fn test_serde_from_table(path: &str) {
     let raw = read_to_string(path).unwrap();
     let result = Table::load_from_str(&raw).unwrap();
-    dbg!(&result);
 
     let material: Expected = from_entry(result.into()).expect("table to material");
     insta::assert_ron_snapshot!(format!("table_to_material__{}", path), material);

tests/snapshots/parse__tests__data__messy.vdf.snap

@@ -15,8 +15,10 @@ expression: parsed
       "2",
       "3",
     ],
+    "bracket_string": "[{]",
     "empty": "",
     "empty quoted": "\"\"",
+    "ignored_bracket_string": "[{]",
     "windows_path": "C:\\test\\no newline",
   },
 }

tests/snapshots/serde__table_to_material__tests__data__messy.vdf.snap

@@ -10,6 +10,7 @@ r#Resource/specificPanel.res(
     3,
   ],
   windows_path: "C:\\test\\no newline",
+  bracket_string: "[{]",
   r#\\"$translucent": true,
   r#$envmaptint: (0.5, 0.5, 0.5),
 )

tests/snapshots/serde__tests__data__messy.vdf.snap

@@ -10,6 +10,7 @@ r#Resource/specificPanel.res(
     3,
   ],
   windows_path: "C:\\test\\no newline",
+  bracket_string: "[{]",
   r#\\"$translucent": true,
   r#$envmaptint: (0.5, 0.5, 0.5),
 )